Add 'Edit template' and 'Back to page' commands #51364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add commands specific to editing a page in the site editor to the command centre.
noisysocks
added
[Type] Bug
noisysocks
force-pushed
the
add/page-content-focus-commands
branch
from
2033531 to
8074046
Compare
|
Size Change: +1.19 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b39b7f2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5249886554
|
|
'Edit template' seems good to add. We'll probably want 'Switch template' too at some point. I'm less confident about 'Back to page', since the command palette already has that action built-in. But I suppose it is beneficial in a keyboard flow. It does seem highly contextual though, so I'd be inclined to place it at the top of the list of commands. Currently it appears below 'Reset...': 
|
+1 to top of the list. |
|
I changed the order to be:
|
|
There are probably more suitable commands to place at the top of the list in the page editing context (#50407), but I guess we can cross that bridge when we get to it. |
andrewserong
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
This feels really nice, and the code looks good 👍
✅ Edit template command is shown when page has focus
✅ Back to page command is shown when template has focus
✅ Back to page is not shown when editing a template directly without a page loaded
| Edit Template | Back to Page |
|---|---|
 |
 |
LGTM! ✨
noisysocks
added
the
[Feature] Page Content Focus
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Add 'Edit template' and 'Back to page' commands Add commands specific to editing a page in the site editor to the command centre. * Re-order template commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds contextual 'Edit template' and 'Back to page' commands to the command centre when the user is editing a page in the site editor.
Also fixes #51262 by hiding template-specific commands when the user is focused on editing page content.
Why?
Nice to have commands available for power users.
How?
Testing Instructions
Screenshots or screencast
Kapture.2023-06-09.at.15.03.17.mp4