Fix navigation error in library #51589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Bug
| @@ -3,6 +3,11 @@ | |||
| } | |||
|
|
|||
| .edit-site-sidebar-navigation-screen-navigation-menus__content { | |||
| // Escapes the padding from the parent block, when showing the navigation items. | |||
| // Grid units aren't accurate enough to use here. | |||
| margin-left: -10px; | |||
getdave
approved these changes
Jun 16, 2023
|
Size Change: +5 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f1db8aa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5291294142
|
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Navigation: Browse Mode: Fix misaligned ellipsis * use a more accurate value * update comment * revert unrelated change * Navigation in Browse Mode: Fix error in Library * revert CSS change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When a navigation has a title, when we try to show that navigation in a template part in the sidebar, the editor crashes. We should be accessing the rendered property of the title, not the whole object.
Why?
To display the correct title, rather than a WSOD.
How?
Access the correct property of the title object, if it exists.
Testing Instructions
This only seems to happen on some themes, I'm not sure why.
This is the direct URL: /wp-admin/site-editor.php?postType=wp_template_part&postId=scruffian-themes%2Fconsole%2F%2Fheader
Testing Instructions for Keyboard
As above