-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behaviors: Move behaviors code to experimental folder. #51654
Conversation
Flaky tests detected in a17dfb1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5312382341
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough about how the experimental/
versus compat/
folders work and their implications to offer an approving review, though I can say that I've tested the lightbox functionality and all seems to working as expected 👍
This makes sense to me. PHP changes in It means, for example, that folks who are still running, say, WordPress 6.2, can still use 6.3-compatible features if they have the Gutenberg plugin installed. It also acts as a guide for us so that we have a good idea about which features have made it to Core and which haven't 😄 More info over at the README: Line 1 in 32d394c
So if the changes in this PR are not being ported to WordPress 6.3 then I think Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🙂
What?
Behaviors are not getting to 6.3. Due to that reason, the code should still be in experimental.