Fix flakiness of saving entities in the site editor #51728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Automated Testing
|
Flaky tests detected in 6e5e1ce. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5373278307
|
kevin940726
force-pushed
the
fix/saving-site-editor-flakiness
branch
from
6b5ed01 to
6e5e1ce
Compare
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Save flakiness of saving entities in the site editor e2e tests.
Why?
I've been noticing some flakiness when running the
template-parte2e tests in the site editor (especiallycan detach blocks from a template part).How?
Instead of waiting for a CSS class, which is an implementation detail, we wait for a notice snackbar instead.
Testing Instructions
CI should pass.