Global Styles: Fix push to global styles for borders and preset attributes #52816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
|
I'm not sure if we are 100% sure we want to include these fixes this late into the 6.3 release cycle. The original PR for these fixes can't be merged to trunk and backported as trunk now contains non-6.3 changes. As noted on the original PR, the bugs these changes address aren't showstoppers so perhaps bumping this PR and the original issue from 6.3 to give it all more time to cook is the wise move. Given that, I'm happy to close this PR once we have a decision. What do others think? |
|
Size Change: +498 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
The latest plan is to bump this fix from 6.3 so I'll close this PR. I also based it off the wrong branch 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Fixes the following without bringing in non-6.3 changes:
Some changes from later Gutenberg releases have been included as well to minimise conflicts when backporting this to the 6.3 RC.
Why?
Without these fixes the push to global styles feature is broken.
How?
Changes included to make conflict resolution easier:
Changes to fix pushing of global styles etc:
cleanEmptyObjectto prevent empty objects for properties within the block style attribute objectTesting Instructions
Screenshots or screencast
Screen.Recording.2023-06-18.at.7.34.45.pm.mp4