-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Site Editor: Allow display of pattern blocks for Pages #53166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
An existing feature does not function as intended
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
[Block] Pattern
Affects the Patterns Block
labels
Jul 31, 2023
Size Change: -6 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
FWIW, If I add |
Closing in favour of #53169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Pattern
Affects the Patterns Block
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
NOTE: This isn't really a full solution but more a starting point for further debugging.
With this PR's tweak applied
wp:pattern
blocks in templates will display for Pages in the Site Editor. Unfortunately, template parts that referencewp:pattern
blocks provided via themes still appear to not renderWhat?
Allow display of
wp:pattern
block when displaying a Page in the Site Editor.Why?
Without this, any Page using a Template containing a theme or core pattern will not render the pattern when visited via the Site Editor.
How?
Relocate the disabling of block editing to the HoC for the
editor.BlockEdit
filter.Testing Instructions
Screenshots or screencast