Fix Cover block flicker (with improved heuristics for light/dark theme) #53375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A >50% dimmed block should use the overlay color for computation; otherwise, the media should be used as shown in this table. | >50% dimmed | media isDark | overlayColor isDark | setIsDark() | |:----------- |:------------ |:------------------- |:----------- | | false | false | false | false | | false | false | true | false | | false | true | false | true | | false | true | true | true | | true | false | false | false | | true | false | true | true | | true | true | false | false | | true | true | true | true |
This reverts commit 7f87feb.
Co-authored-by: Glen Davies <[email protected]>
|
Size Change: +55 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
This was referenced Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the potential for unending state/store update loops in the Cover blocks’s hook for determining light/dark theme.
For now this includes the changes from #45076 for easy testing.
Why?
The flicker that can be experienced is awful. To fix #53211
How?
Removes the local state from the hook to directly use store state.
Testing Instructions
templatesdirectory).my-template.html, add the synced block pattern. To get the markup to add to the template, you can add the synced pattern to a post or page, then view the code editor view and copy + paste to yourmy-template.htmlfilemy-template.html.Example markup from my
my-template.htmlfile: