Improve command palette rendering on smaller viewports #53661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
|
Size Change: +870 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d168096. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5862306973
|
|
Seems fine, but should the radius be changed like that? To me this counts as a modal and can keep its modal radius. Not the strongest opinion in the world, just curiuos as to the intent. |
If not, then we should adjust the width so that it's fullwidth on mobile - like other modals are, but that looks off as the height changes based on the result count. As-is, the radius is 0 on the bottom. Here's what the modal would look like, treated exactly like the modal component: |
|
Should we add some margin on mobile, and keep the radius, so it isn't styled as a "bottom card" like that? |
|
CC: @jameskoster I think you polished these recently. |
You mean for the modal component? Perhaps. |
|
I meant an override just for the command palette. But I guess the larger question is how that should behave on mobile altogether, so a big old "depends" on that one. |
|
For reference, this is what modals look like currently: 
Compared to the command palette (which grows based on command results): 
|
|
An alternative would be to apply a min height on mobile to the command palette. Brings it more in line with modal, if that's what we want (should probably have a close button too then on mobile).
|
|
I could go quite a few ways on this one, including just picking one and revisiting as we learn more about this, so I'm happy to defer. I think the only change I'd feel slightly more about is to retaining the 4px radius :) |
Just realized I used the wrong unit — I'll fix :) |
|
@jasmussen I updated the description with before/after recordings of the change. |
richtabor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Minor adjustment to
.commands-command-menuto improve how it displays on mobile.Testing Instructions
Screenshots or screencast
Before
CleanShot.2023-08-15.at.13.30.37.mp4
After
CleanShot.2023-08-15.at.13.28.12.mp4