Capture toolbars in navigation block #53697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
|
Size Change: +13 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
I think we've tried this for navigation in the past, and ended up moving away from it. But that was a long while back, still with the old UI, I believe, and at the time if I recall correctly, the reason we didn't go with it was that the mover controls were too far from the selected block.
Since then the block outline being visible while you are interacting with the block addresses this, and comes with the benefit of a single clickable place that doesn't move with the block itself:
As such, I think this is an improvement:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related to #53306, trying out toolbar capture on the Navigation block.
Why?
Experimenting with improving nested block experiences.
Testing Instructions
Screenshots or screencast
Before
Notice how the toolbar moves with you:
CleanShot.2023-08-15.at.14.34.13.mp4
After
Notice how the toolbar stays in place:
CleanShot.2023-08-15.at.14.33.05.mp4