Add missing aria roles to the 'Replace template part' menu item #53755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Focus] Accessibility (a11y)
Mamaduka
requested review from
talldan,
andrewserong and
alexstine
and removed request for
ajitbohra
|
Size Change: +8 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
This is working nicely and matches the approach you've used in other approved PRs (e.g. #53734) 👍
✅ Attributes look correct
✅ aria-expanded correctly toggles with the modal being opened or not
LGTM! ✨
Mamaduka
force-pushed
the
add/replace-template-part-menu-item-aria-roles
branch
from
f189506 to
ea46c72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #24796.
This is similar to #53754.
PR adds the missing aria roles to the "Replace template part" menu item.
Why?
The menu item opens a dialog but lacks the
aria-expandedandaria-haspopupattributes.Testing Instructions
Testing Instructions for Keyboard
Same
Screenshots or screencast