Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the components changelog to mark the popover slot removal as a breaking change #54022

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Update the components changelog to mark the popover slot removal as a breaking change #54022

merged 2 commits into from
Aug 31, 2023

Conversation

youknowriad
Copy link
Contributor

Follow-up to #53982 (comment)

@youknowriad youknowriad added [Type] Developer Documentation Documentation for developers [Feature] UI Components Impacts or related to the UI component system labels Aug 29, 2023
@youknowriad youknowriad requested a review from ciampo August 29, 2023 13:28
@youknowriad youknowriad self-assigned this Aug 29, 2023
@youknowriad youknowriad requested a review from ajitbohra as a code owner August 29, 2023 13:28
ciampo
ciampo approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the follow-up, Riad.

Would it be able to also address some of the comments left by @tyxla in the previous PRs, like fixing this typo ?

Feel free to merge once feedback is addressed :)

packages/components/CHANGELOG.md Outdated Show resolved Hide resolved
@youknowriad
Copy link
Contributor Author

Would it be able to also address some of the comments left by @tyxla in the previous PRs, like fixing this #53889 (comment) ?

These have been addressed already.

@youknowriad youknowriad enabled auto-merge (squash) August 30, 2023 13:54
@youknowriad youknowriad disabled auto-merge August 31, 2023 04:30
@youknowriad youknowriad merged commit d67a8d5 into trunk Aug 31, 2023
@youknowriad youknowriad deleted the update/components-changelog branch August 31, 2023 04:31
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Aug 31, 2023
@ciampo ciampo mentioned this pull request Sep 12, 2023
Merged
@ciampo ciampo mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciampo ciampo ciampo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@youknowriad youknowriad

Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 16.7
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowriad @ciampo