Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport tools: filter PRs to be cherry picked by merged date #54171

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Sep 5, 2023

What?

A follow up to:

This PR removes the closed_at fallback when remapping fetched PRs.

Why?

We only want merged PRs so we filter then use by merged_at.

closed_at might catch closed PRs that have not been merged.

Testing Instructions

As in #52667 you can test against any set of Gutenberg PR labels on a test branch by running npm run other:cherry-pick "LABEL_NAME"

npm run other:cherry-pick alone will run against the "Backport to WP Beta/RC" label.

@ramonjd ramonjd added the [Type] Build Tooling Issues or PRs related to build tooling label Sep 5, 2023
@ramonjd ramonjd requested a review from ntwb as a code owner September 5, 2023 03:50
@ramonjd ramonjd self-assigned this Sep 5, 2023
Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This should prevent PRs closed without merging from accidentally getting cherry-picked.

@ramonjd ramonjd enabled auto-merge (squash) September 5, 2023 05:59
@ramonjd ramonjd merged commit 9d7892e into trunk Sep 5, 2023
@ramonjd ramonjd deleted the update/cherry-pick-script-merged_at branch September 5, 2023 06:30
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants