Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs: Getting Started / Block Development Environment] Updates on the text to improve clarity and preciseness #54563

Merged

Conversation

juanmaguitar
Copy link
Contributor

What?

Minor changes to some texts of the "Getting Started / Block Development Environment" section to improve clarity and preciseness

Why?

To avoid confusion and have a more coherent narrative that helps developers understand and process this information faster.

Copy link
Member

@ndiego ndiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added a few grammatical tweaks.

@@ -32,7 +32,7 @@ The list goes on. While modern JavaScript development can be challenging, WordPr

**The recommended Node.js version for block development is [Active LTS](https://nodejs.dev/en/about/releases/) (Long Term Support)**. However, there are times when you need to to use different versions. A Node.js version manager tool like `nvm` is strongly recommended and allows you to easily change your `node` version when required. You will also need Node Package Manager (`npm`) and the Node Package eXecute (`npx`) to work with some WordPress packages. Both are installed automatically with Node.js.

To install Node.js development tools and learn more about each, refer to the links below.
To be able to use the [Node.js tools and packages provided by WordPress](https://github.com/WordPress/gutenberg/tree/trunk/packages) for block development you'll need to set a proper Node.js runtime environment in your machine. To learn more about how to do this, refer to the links below.
Copy link
Member

@ndiego ndiego Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be able to use the Node.js tools and packages provided by WordPress for block development, you'll need to set a proper Node.js runtime environment on your machine.

@@ -13,7 +13,7 @@ The Node Package eXecute ([`npx`](https://docs.npmjs.com/cli/v10/commands/npx))

It's recommended that you use [Node Version Manager](https://github.com/nvm-sh/nvm) (`nvm`) to install Node.js. This allows you to install and manage specific versions of `node`, which are installed locally in your home directory, avoiding any global permission issues.

Here are the quick instructions for installing `node` using `nvm`. See the [complete installation guide](https://github.com/nvm-sh/nvm#installing-and-updating) for more details.
Here are the quick instructions for installing `node` using `nvm` and set the recommended Node version for block development. See the [complete installation guide](https://github.com/nvm-sh/nvm#installing-and-updating) for more details.
Copy link
Member

@ndiego ndiego Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the quick instructions for installing node using nvm and setting the recommended Node.js version for block development.

@juanmaguitar
Copy link
Contributor Author

I have added more changes to this PR that include:

  • this and this feedback incorporated
  • Changed "Node.js development tools" section title to "Node development environment"
  • Changed nodejs-development-tools.md filename to node-development-environment.md
  • Updated manifest.json and toc.json to reflect filename changes
  • Fixed links pointing to each Node install sections

@ndiego let me know your thoughts

@juanmaguitar juanmaguitar requested a review from ndiego September 18, 2023 16:46
Copy link
Member

@ndiego ndiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

@juanmaguitar juanmaguitar merged commit a319bfd into trunk Sep 18, 2023
@juanmaguitar juanmaguitar deleted the docs/minor-adjustments-develop-environment-section branch September 18, 2023 18:11
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants