-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a brief description to the Footnotes block #54613
Add a brief description to the Footnotes block #54613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aurooba This looks good. Please run npm run docs:build
locally to build the required doc changes. Then commit those and this should be good to land pending any further feedback.
@alexstine thank you for that reminder. I always forget that running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aurooba Are these changes related? Don't think so.
packages/compose/README.md
Might want to check them out over latest trunk.
Alright, let's see if that gets us green checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@alexstine thanks! I didn't get notified of the comments on these somehow, oops. I appreciate you fixing it up! 🙏🏽 |
What and Why?
I noticed there was no description for the Footnotes block. This PR adds a brief one in a similar style to other Core Block descriptions:
Display footnotes added to the page.
. Happy to adjust based on feedback!