-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patterns: add a new spec for for adding an unsynced pattern #54892
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e0d6e56
Add a new spec for for adding an unsynced pattern
glendaviesnz d10bd06
Add additional check to make sure the new pattern gets inserted back …
glendaviesnz ee4d6dc
Fix typo
glendaviesnz bb55067
Remove redundant label click
glendaviesnz 368e4be
Changes from code review
glendaviesnz d6fa2eb
Simplify the block comparison
glendaviesnz 51487fa
Fix typo
glendaviesnz 376542d
Name the checkbox
glendaviesnz df0fead
Fix linting
glendaviesnz 8c3a829
Fix and tweak test
kevin940726 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
const { test, expect } = require( '@wordpress/e2e-test-utils-playwright' ); | ||
|
||
test.describe( 'Unsynced pattern', () => { | ||
test.beforeAll( async ( { requestUtils } ) => { | ||
await requestUtils.deleteAllBlocks(); | ||
} ); | ||
|
||
test.beforeEach( async ( { admin } ) => { | ||
await admin.createNewPost(); | ||
} ); | ||
|
||
test.afterEach( async ( { requestUtils } ) => { | ||
await requestUtils.deleteAllBlocks(); | ||
} ); | ||
|
||
test( 'create a new unsynced pattern via the block options menu', async ( { | ||
editor, | ||
page, | ||
} ) => { | ||
await editor.insertBlock( { | ||
name: 'core/paragraph', | ||
attributes: { content: 'A useful paragraph to reuse' }, | ||
} ); | ||
const before = await editor.getBlocks(); | ||
|
||
// Create an unsynced pattern from the paragraph block. | ||
await editor.showBlockToolbar(); | ||
await page | ||
.getByRole( 'toolbar', { name: 'Block tools' } ) | ||
.getByRole( 'button', { name: 'Options' } ) | ||
.click(); | ||
await page.getByRole( 'menuitem', { name: 'Create pattern' } ).click(); | ||
|
||
const createPatternDialog = page.getByRole( 'dialog', { | ||
name: 'Create pattern', | ||
} ); | ||
await createPatternDialog | ||
.getByRole( 'textbox', { name: 'Name' } ) | ||
.fill( 'My unsynced pattern' ); | ||
await createPatternDialog | ||
.getByRole( 'checkbox', { name: 'Synced' } ) | ||
.setChecked( false ); | ||
|
||
await page.keyboard.press( 'Enter' ); | ||
|
||
// Check that the block content is still the same. If the pattern was added as synced | ||
// the content would be wrapped by a pattern block. | ||
await expect | ||
.poll( | ||
editor.getBlocks, | ||
'The block content should be the same after converting to an unsynced pattern' | ||
) | ||
.toEqual( before ); | ||
|
||
// Check that the new pattern is available in the inserter and that it gets inserted as | ||
// a plain paragraph block. | ||
await page.getByLabel( 'Toggle block inserter' ).click(); | ||
await page | ||
.getByRole( 'searchbox', { | ||
name: 'Search for blocks and patterns', | ||
} ) | ||
.fill( 'My unsynced pattern' ); | ||
await page.getByLabel( 'My unsynced pattern' ).click(); | ||
|
||
// Just compare the block name and content as the clientIDs will be different. | ||
before.forEach( ( block ) => { | ||
delete block.clientId; | ||
} ); | ||
await expect | ||
.poll( editor.getBlocks ) | ||
.toMatchObject( [ ...before, ...before ] ); | ||
} ); | ||
} ); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, that is much simpler 🤦