Changing Button component toggled style selector
#55065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverting change from class to attribute selector, until we can better assess how the `is-pressed` class is used elsewhere.
andrewhayward
added
[Type] Bug
ciampo
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: -44 B (0%) Total Size: 1.64 MB
ℹ️ View Unchanged
|
t-hamano
removed
the
Backport to WP 6.7 Beta/RC
|
Thanks for the PR! This change looks good to me, but I would appreciate a second review from those who worked on #54740. Note: I removed the backport label. Because #54740, which this PR is trying to solve, is not shipped in WP6.4. WP6.4 Beta2 does not have the problem that this PR is trying to solve. |
ciampo
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR changes how a toggled
Buttonis styled, reverting the change from class to attribute selector in #54740.Why?
It was not properly anticipated that
Buttonconsumers might be relying on the.is-pressedclass for styling, so until we can better assess how.is-pressedis used elsewhere, we should leave it in place.See also #55004.
How?
This PR undoes the selector change in #54740.
Testing Instructions
This is an aesthetic change, so should make no behavioural difference. All unit tests should continue to pass.
Consuming components, including blocks, should also render as before. Any that rely on the presence of
.is-pressed, such as the Search block toolbar, should now look as expected.To test the search block toolbar
Before
After