Add missing labels to changelog script, and enhance mapping function. #55066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
|
@vcanales Code looks good. Testing instructions? |
Thanks for taking a look. Running |
|
Flaky tests detected in fc5e057. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6452664647
|
|
@priethor I've added a few more test cases and updated snapshots and fixtures; for the latter, I used the output for |
vcanales
force-pushed
the
add-command-package-label-to-changelog
branch
from
fc5e057 to
d8dbe40
Compare
|
Pinging @priethor; friendly reminder! |
priethor
approved these changes
Nov 30, 2023
added 5 commits
December 1, 2023 11:03
Avoids missing mappings due to capitalization mismatch. eg. at the time of this change, the code looked for [Package] Block Editor, but on GitHub the label is actually typed [Package] Block editor — PRs labeled as such, were being sorted under Various.
vcanales
force-pushed
the
add-command-package-label-to-changelog
branch
from
d8dbe40 to
7f5e787
Compare
vcanales
added
the
Backport to Gutenberg RC
vcanales
added a commit
that referenced
this pull request
Dec 6, 2023
…#55066) * Add Commands package label as a changelog feature * Compare labels using lowercase values Avoids missing mappings due to capitalization mismatch. eg. at the time of this change, the code looked for [Package] Block Editor, but on GitHub the label is actually typed [Package] Block editor — PRs labeled as such, were being sorted under Various. * Add site editor label * Add tests for case insensitivity * Update fixtures and snapshots
|
Backported to Gutenberg 17.2 RC |
vcanales
removed
the
Backport to Gutenberg RC
cbravobernal
pushed a commit
that referenced
this pull request
Dec 7, 2023
…#55066) * Add Commands package label as a changelog feature * Compare labels using lowercase values Avoids missing mappings due to capitalization mismatch. eg. at the time of this change, the code looked for [Package] Block Editor, but on GitHub the label is actually typed [Package] Block editor — PRs labeled as such, were being sorted under Various. * Add site editor label * Add tests for case insensitivity * Update fixtures and snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Compare labels using lowercase values.
Avoids missing mappings due to capitalization mismatch. eg. at the time
of this change, the code looked for [Package] Block Editor, but on
GitHub the label is actually typed [Package] Block editor — PRs labeled
as such, were being sorted under Various.
Add site editor label.
Add commands package label.