Refactor Site Editor Document Tools Navigation to own component #55770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +101 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
jeryj
changed the title
|
Flaky tests detected in f9cacb4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6721803125
|
scruffian
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactoring the site editor document tools header navigation to be its own component.
Why?
This brings it in line with the other site headers. It will also make the work from #54513 be much easier to review since it won't include as many changes, and this is a useful refactor for ease of reading and use regardless.
How?
<DocumentTools />component. Named that as the aria-label isDocument Tools.<DocumentTools />component via propsTesting Instructions
There should be no functional changes. All tests should pass.