ListViewBlock: Combine 'useSelect' hooks #55889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
Mamaduka
requested review from
scruffian,
noisysocks,
jsnajdr,
tyxla and
andrewserong
and removed request for
ellatrix
|
Size Change: +16 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
jsnajdr
approved these changes
Nov 6, 2023
|
Nice one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR combines multiple
useSelecthook calls into a single one for theListViewBlockcomponent.Why?
All hooks have the same dependency and are selected from the same store. There's no need to create 3 store subscriptions. The store subscription numbers can add up when working with large posts. See #54819 (comment).
Testing Instructions
There's no functionality change. Smoke-test the list view and confirm CI checks are passing.