Lightbox: Fix button misalignment in gallery image #56060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
requested review from
artemiomorales,
michalczaplinski and
SantosGuillamot
|
Size Change: +29 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
michalczaplinski
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Great catch @t-hamano .
Thank you for the comprehensive PR description, too. It helped to understand quickly what your fix is actually doing.
cbravobernal
pushed a commit
that referenced
this pull request
Nov 14, 2023
oandregal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56058
What?
This PR fixes an issue where the Lightbox toggle button is misaligned when the image is in a gallery block and has a caption.
Before
After
Why?
When positioning the button, the height of the caption is taken into account because if the image has a caption, the figure element will be taller than the image. However, the caption of the image block inside the gallery block has the
position:absolutestyle by default, so it does not affect the height of the figure element. As a result, the button's position is shifted up by the height of the caption.How?
Does not take into account the height of the caption when the position property of the caption is
absoluteorfixed. Althoughposition:fixedmay be rarely applied, this style also does not affect the height of the figure element.Testing Instructions