Site editor: Try lighter menu item color. #56137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous color, gray 600 had 5.5:1 contrast against the background, more than the AA requires, but it could still be perceived as low contrast. This new color has 10.38:1 contrast, more than AAA.
|
This PR could potentially benefit from the contrast preference discussed here. |
|
Size Change: +6 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Closing this for now, but we can revisit if need be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The previous color, gray 600 had 5.5:1 contrast against the background, more than the AA requires. This new color has 10.38:1 contrast, more than AAA.
Why?
I think it's worth having the conversation about the role of contrast here, in both the before and after cases here, there is objectively sufficient contrast according to accepted standards. In the latter, the contrast is perceived higher, but this comes at the tradeoff of lower contrast between text and menu items.
Testing Instructions
Open the site editor and observe the AAA contrast between text and background.
Before:
After:
Another option is to swap the colors, so the intro text has AA contrast and the link items has AAA: