DataViews: extract common constants to file #56251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Experimental
oandregal
requested review from
jorgefilipecosta,
ntsekouras and
youknowriad
|
Size Change: -13 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Nov 17, 2023
| @@ -31,6 +31,7 @@ import { | |||
| import SideEditor from './side-editor'; | |||
| import Media from '../media'; | |||
| import { unlock } from '../../lock-unlock'; | |||
| import { ENUMERATION_TYPE, OPERATOR_IN } from '../dataviews/constants'; | |||
There was a problem hiding this comment.
This import and the next one assume that the future "data views" package would export these constants as well. I'm not sure I like exporting constants from a package to another but I guess when we extract the package we can either duplicate these constants in edit-site as well or replace them with strings.
youknowriad
approved these changes
Nov 17, 2023
oandregal
deleted the
add/constants-for-field-types-and-filter-operators
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
Extracts a couple of common constants to its own
constants.jsfile.Why?
To centralize where they live.
How?
Create a new
constant.jsfile.Testing Instructions