Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update template name in create-block command #56281

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Update template name in create-block command #56281

merged 1 commit into from
Nov 19, 2023

Conversation

juanmaguitar
Copy link
Contributor

Update template name in create-block command

What?

Update the create-block command to

npx @wordpress/create-block copyright-date-block --template @wordpress/create-block-tutorial-template

Why?

The template needs to be called as @wordpress/create-block-tutorial-template

@juanmaguitar
Update quick-start-guide.md
9c5fc29 
Update proper link for template
@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label Nov 18, 2023
@t-hamano t-hamano self-requested a review November 18, 2023 12:50
t-hamano
t-hamano approved these changes Nov 18, 2023
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍I also confirmed that the command actually works.

@juanmaguitar juanmaguitar merged commit 1646cd8 into trunk Nov 19, 2023
@juanmaguitar juanmaguitar deleted the quick-start-guide-update-template-name branch November 19, 2023 12:36
@github-actions github-actions bot added this to the Gutenberg 17.2 milestone Nov 19, 2023
@ndiego
Copy link
Member

ndiego commented Nov 19, 2023

Good catch! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@ndiego ndiego Awaiting requested review from ndiego ndiego is a code owner

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 17.2
Development

Successfully merging this pull request may close these issues.
3 participants
@juanmaguitar @ndiego @t-hamano