Dataviews: Update item actions in grid view #56501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Experimental
ntsekouras
requested review from
youknowriad,
oandregal,
jameskoster,
SaxonF and
ciampo
|
Size Change: +119 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Nov 24, 2023
|
Seems to be working well for me: 
Seeing the menu in practise makes me think we can probably simplify by removing the icons and separator. Those are likely to be more useful when additional secondary actions are added. 
Side note: The ellipsis icon in the trigger seems to be blue in its resting state. Generally icon buttons are dark gray ( |
Hm.. in Chrome for me it isn't, but tested in FF and is displayed as I expected. --edit |
|
It's likely that you were previously running Chrome 116 (or earlier), since support for CSS Subgrid was added in Chrome 117. |
ntsekouras
force-pushed
the
update/dataviews-actions-in-grid
branch
from
a859b60 to
9e2752d
Compare
|
I removed the icons and the separators.
That was because of |
youknowriad
reviewed
Nov 27, 2023
|
Am I not seeing right or the border radius of that dropdown is different than the "view" dropdown for instance? Should we unify everything? |
|
Also, not the same hover styles... Why two different dropdown styles? |
In this PR I'm using the new Dropdown menu and @ciampo has a PR to update all the other usages in a different PR. |
youknowriad
approved these changes
Nov 27, 2023
The new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the item actions in DataViews to have a different design in
gridview. Namely all the actions are inside a dropdown menu, separated by whether they are primary or not.Additionally I have used the new Dropdown component that we use in DataViews, for consistency. I know this is going to be replaced by the ariakit version one, but when I tried adding that, I encountered way more problems right now. When the new one is stabilized, we're going to replace all usages.
Testing Instructions
Screenshots or screencast