Editor styles: scope without adding specificity #56564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
oandregal,
jasmussen,
michalczaplinski and
andrewserong
|
Size Change: +109 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in eecacc1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7007483129
|
@michalczaplinski It did or it didn't? I checked your video and it seems to work after you check out the branch at the end? |
|
Or did you mean before you added the commit? :) |
andrewserong
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Thanks @ellatrix and @michalczaplinski, this is testing great for me!
To reproduce, I edited my theme's theme.json to set a couple of the fontSizes to use slugs that match these default rules for normal and huge font sizes.
| Before (defaults override theme.json styles) | After (theme.json rules win out) |
|---|---|
 |
 |
Looks like the rules are all still output (with lower specificity) for the backwards compatibility / fallback cases.
LGTM! ✨
|
Awesome! |
Yeah, exactly. Sorry, I didn't phrase it super clearly 🙂 |
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This should fix #56293, but I'm not familiar enough to understand how to test. Would appreciate testing.
Why?
Editor styles with hardcoded and unconditional scoping (.editor-styles-wrapper) add extra CSS specificity, which causes unscoped CSS to be overridden.
How?
Using
:where(.editor-styles-wrapper)should remove this specificity.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast