(RichText)(Workaround)(17.1.x) Fallback to a string arg in collapseWhiteSpace() if value is not a string
#56570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
…id TypeErorrs See the comments in this changeset for more info on why this was needed.
fullofcaffeine
force-pushed
the
workaround/for-null-value-rich-text-component
branch
from
9c732af to
2bb1c16
Compare
fullofcaffeine
requested review from
ellatrix,
fluiddot and
dcalhoun
as code owners
anomiex
approved these changes
Nov 27, 2023
Yeah, I don't like changing the argument's value either. I think your suggestion of a more localized fix makes sense. Done in 0eecb37. This is really a laser-focused fix based on the stacktrace of the unhandled exception that prevents the block from rendering, but I haven't seen any other failures due to the |
anomiex
approved these changes
Nov 27, 2023
fullofcaffeine
commented
Nov 27, 2023
| @@ -71,7 +71,9 @@ export function useRichText( { | |||
| function setRecordFromProps() { | |||
| _value.current = value; | |||
| record.current = create( { | |||
| html: preserveWhiteSpace ? value : collapseWhiteSpace( value ), | |||
| html: preserveWhiteSpace | |||
| ? value | |||
There was a problem hiding this comment.
I tested the scenario with presrveWhiteSpace = true and it doesn't crash, so the problem seems limited to the collapseWhiteSpace call.
fullofcaffeine
changed the title
fullofcaffeine
changed the title
collapseWhiteSpace() if value is not a string
fullofcaffeine
deleted the
workaround/for-null-value-rich-text-component
branch
fullofcaffeine
added a commit
that referenced
this pull request
Nov 28, 2023
…hiteSpace()` if `value` is not a string (#56570) * (RichText)(Fix)(Workaround) Make sure value is always a string to avoid TypeErorrs See the comments in this changeset for more info on why this was needed. * Use a more localized fix that does not change the argument
fullofcaffeine
added
[Type] Bug
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
…hiteSpace()` if `value` is not a string (#56570) * (RichText)(Fix)(Workaround) Make sure value is always a string to avoid TypeErorrs See the comments in this changeset for more info on why this was needed. * Use a more localized fix that does not change the argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a safeguard type-check that sets the
valueto''if it's not a string in theRichTextcomponent.A better solution would be to figure out why
nullis being passed there, but this seems to be a feasible temporary workaround if we don't get to the real culprit.Why?
The issue that led to this fix was found in the
Multi-Line Text Field block, provided by Jetpack. The block is completely broken in 17.1.2 and (current)trunk`.How?
By passing an empty string to the
collapseWhiteSpaceifvalueis not a string.Testing Instructions
Multi-Line Text Field;This block has encountered an error and cannot be previewed.is rendered;Multi-Line Text Fieldblock to the page and notice how it render and works correctly now.Testing Instructions for Keyboard
Screenshots or screencast