-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataViews: Add story #56761
DataViews: Add story #56761
Conversation
Size Change: +29 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
@@ -3,6 +3,7 @@ | |||
height: calc(100% - #{$grid-unit-40} * 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we handle it in a way that works everywhere (regardless of how dataviews is used)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can test the story outside of the Storybook canvas iframe (example) to understand if the iframe could be the issue here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very cool PR.
It shows another issue for me. I believe we should have a way to disable useAsyncList
by default and only enable it on demand. For this static performant data views, there's no need to enable it for instance.
#66727 fixes the order of styles, by loading component before dataviews' styles. The issue was raised at #56760 (comment) |
What?
This PR adds a basic story for DataViews component to enable UI development on isolation. I discovered a couple of issues already that are being addressed here.
Testing Instructions
npm run storybook:dev
and test the component.