Hide sibling inserter in zoomed out mode #56891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Feature] Inserter
|
Size Change: -133 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
kevin940726
merged commit 9dee4b6
into
try/zoomed-out-mode-experiments
55 of 56 checks passed
aaronrobertshaw
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
LGTM 👍
✅ Sibling inserter is hidden in zoom out mode
✅ Sibling inserter is still present outside zoom out mode
When it comes time to progress these zoom out mode enhancements beyond an experiment, we might also be able to remove the ZoomOutModeInserters component entirely.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the sibling inserter for the zoomed out mode experiments (#56806).
Why?
As part of the experiments, zoomed out mode is instigated by opening patterns in the inserter. The problem is the inserter acts as a dialog, so clicking something like the sibling inserter immediately closes it and results in zoomed out mode also being exited.
For this timeboxed experiment, there isn't enough time to look at solutions, so the quick fix is to remove the inserter.
It perhaps also doesn't make sense to show the sibling inserter when the main inserter menu is already open.
How?
Delete it
Testing Instructions
In trunk: Sibling inserters are displayed in the canvas
In this PR: No sibling inserters (drag and drop indicators are still shown)
Screenshots or screencast
Before
After