Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing test when top toolbar is mounted #56908

Closed
wants to merge 1 commit into from
Closed

Add typing test when top toolbar is mounted #56908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/performance/config/performance-reporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export interface WPRawPerformanceResults {
firstContentfulPaint: number[];
firstBlock: number[];
type: number[];
typeWithTopToolbar: number[];
typeWithoutInspector: number[];
typeContainer: number[];
focus: number[];
Expand All @@ -49,6 +50,7 @@ export interface WPPerformanceResults {
type?: number;
minType?: number;
maxType?: number;
typeWithTopToolbar: number;
typeWithoutInspector?: number;
typeContainer?: number;
minTypeContainer?: number;
Expand Down Expand Up @@ -94,6 +96,9 @@ export function curateResults(
type: average( results.type ),
minType: minimum( results.type ),
maxType: maximum( results.type ),
typeWithTopToolbar: average( results.typeWithTopToolbar ),
minWithTopToolbarType: minimum( results.typeWithTopToolbar ),
maxWithTopToolbarType: maximum( results.typeWithTopToolbar ),
Comment on lines +100 to +101
Copy link
Member

@WunderBart WunderBart Dec 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's skip those. We didn't include them with the recently added typeWithToolbar as well.

typeWithoutInspector: average( results.typeWithoutInspector ),
typeContainer: average( results.typeContainer ),
minTypeContainer: minimum( results.typeContainer ),
Expand Down
25 changes: 25 additions & 0 deletions test/performance/specs/post-editor.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ const results = {
firstContentfulPaint: [],
firstBlock: [],
type: [],
typeWithTopToolbar: [],
typeWithoutInspector: [],
typeContainer: [],
focus: [],
Expand Down Expand Up @@ -149,6 +150,30 @@ test.describe( 'Post Editor Performance', () => {
} );
} );

test.describe( 'Typing with Top Toolbar', () => {
let draftId = null;

test( 'Setup the test post', async ( { admin, perfUtils, editor } ) => {
await admin.createNewPost();
await editor.setIsFixedToolbar( true );
Copy link
Member

@WunderBart WunderBart Dec 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a global, persistent setting so it needs to be reverted after the test or it will affect other metrics. See this PR as an example on how to handle it!

await perfUtils.loadBlocksForLargePost();
await editor.insertBlock( { name: 'core/paragraph' } );
draftId = await perfUtils.saveDraft();
} );

test( 'Run the test', async ( { admin, perfUtils, metrics } ) => {
await admin.editPost( draftId );
await perfUtils.disableAutosave();
const canvas = await perfUtils.getCanvas();

const paragraph = canvas.getByRole( 'document', {
name: /Empty block/i,
} );

await type( paragraph, metrics, 'typeWithTopToolbar' );
} );
} );

test.describe( 'Typing (without inspector)', () => {
let draftId = null;

Expand Down
Loading