Refactor useCanContextualToolbarShow for simplicity and clarity #56914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename to useCanBlockToolbarBeFocused: Each usage of useCanContextualTool barShow ended up as one blockToolbarCanBeFocused const. - The scenarios of when the block toolbar can be focused was much simpler t han the implemented checks. Refactored for the scenarios in which it can be focused.
jeryj
requested review from
draganescu,
talldan,
noisysocks,
tellthemachines,
adamziel,
kevin940726 and
ellatrix
as code owners
|
Size Change: -903 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8a39e75. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7146283837
|
draganescu
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
The fact that no tests fail and none are changed seems dubious with these refactors. That plus the instruction to
Test alt+f10 shortcut in many scenarios.
makes me think this PR or an immediate follow up should include some tests for common scenarios - basically the ones in the hook comment.
Manual testing works 👏🏻 and found a typo.
packages/block-editor/src/utils/use-can-block-toolbar-be-focused.js
Outdated
Show resolved
Hide resolved
…ed.js Co-authored-by: Andrei Draganescu <[email protected]>
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
* Refactor useCanContextualToolbarShow for simplicity and clarity - Rename to useCanBlockToolbarBeFocused: Each usage of useCanContextualTool barShow ended up as one blockToolbarCanBeFocused const. - The scenarios of when the block toolbar can be focused was much simpler t han the implemented checks. Refactored for the scenarios in which it can be focused. * Update packages/block-editor/src/utils/use-can-block-toolbar-be-focused.js Co-authored-by: Andrei Draganescu <[email protected]> --------- Co-authored-by: Ben Dwyer <[email protected]> Co-authored-by: Andrei Draganescu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Simplify conditions of useCanContextualToolbarShow and turn it into useCanBlockToolbarBeFocused, which is what all the implementors of useCanContextualToolbarShow were doing.
Why?
Since #56335 is merged, the conditions for when the toolbar can be focused have been simplified and combined. This both helped me have a better understanding of those conditions, and made it easier to grok. I want to bring those changes over to this hook before I forget about it :)
How?
focused.
Testing Instructions for Keyboard
Test
alt+f10shortcut in many scenarios. The block toolbar, if possible to be focused, should receive focus. If it's not able to be focused, then focus should get sent to the Document Toolbar in the top left (where the block inserter is).Screenshots or screencast