Site editor: remove isResizing variable from layout component as it is always false
#57119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
the
[Type] Code Quality
oandregal
requested review from
SaxonF,
mirka,
ciampo,
WunderBart,
youknowriad,
jorgefilipecosta and
ntsekouras
Merged
oandregal
changed the title
isResizing variable that is always set to falseisResizing variable from layout component as it is always false
oandregal
added
the
[Feature] Site Editor
|
Size Change: +424 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Dec 15, 2023
| @@ -309,10 +308,7 @@ export default function Layout() { | |||
| { isEditorPage && ( | |||
| <div | |||
| className={ classnames( | |||
There was a problem hiding this comment.
The classnames call is useless here as well.
There was a problem hiding this comment.
Good catch, removed it 7b94302
youknowriad
approved these changes
Dec 15, 2023
|
Flaky tests detected in 7b94302. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7225590679
|
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
… is always false (#57119)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the
isResizingvariable, that is always set to false.Why?
It's a leftover from https://github.com/WordPress/gutenberg/pull/49910/files#diff-89e57bfd1de96b1cee155f91aa9754cb37715e9ffa9e4cc2f21463a770f7ec55L121 that removed the
setIsResizingmethod.Testing Instructions
Open the site editor and verify that resizing still works.