Disable webpack perf hints when compiling packages #57155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Build Tooling
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 203c461. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7247485048
|
tyxla
approved these changes
Dec 18, 2023
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
* Disable webpack perf hints when compiling packages * Rewrite reduce to fromEntries in packages webpack config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When webpack builds the
packagesdirectory, it outputs some performance warnings because the bundles are larger than the default limit:This PR disables these warnings because they are mostly spam, we don't really look at and act on them.
As a drive-by, I'm refactoring
.reducetoObject.fromEntriesa few lines up in the same webpack config. Not logically related, just code that's physically close 🙂