Dependencies: Upgrade babel #57311
Merged
Dependencies: Upgrade babel #57311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
changed the title
|
Size Change: +153 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ba56f56. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8298378677
|
desrosj
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Thanks for this @sirreal!
I looked through and this seems like a fine update to make. I went through the Babel changelog and confirmed that there were only bug fixes and new features added.
Also, the simple-git update is long overdue. #47478 will be closed out as a result of this PR.
I ran npm dedupe locally before applying these updates because I wanted to see the impact of the command. This is what I got for output:
added 64 packages, removed 75 packages, changed 220 packages, and audited 4565 packages in 4m
This seems like something we should probably try running more regularly, potentially adding a pre-commit task, or creating a GitHub Action to check for a certain threshold.
I'm approving, but the merge conflicts need to be resolved. And I'd like a second look over from someone closer to the actual Gutenberg code before merging (maybe @gziolo, @ockham, or @youknowriad).
sirreal
force-pushed
the
security-upgrades
branch
from
4d1b56f to
c9a57d3
Compare
|
There is a linting error reported:
Other CI issues need to be investigated but some of them might be related to the npm caching appointment used. |
|
I also see a failing unit test: That one looks unrelated 🤷 |
|
I expected this to be quick, but got stuck with failing tests 🙂 I may need to start with a deduplication only PR, I expect some of the failures are from that. I do have some other higher priority work right now so I'll get back to this when I have time. |
sirreal
force-pushed
the
security-upgrades
branch
from
c9a57d3 to
8329c51
Compare
sirreal
changed the title
sirreal
force-pushed
the
security-upgrades
branch
3 times, most recently
from
fc633a4 to
94e45da
Compare
sirreal
commented
Mar 20, 2024
| "babel-jest": "29.6.2", | ||
| "babel-loader": "8.2.3", | ||
| "babel-jest": "29.7.0", | ||
| "babel-loader": "9.1.3", |
There was a problem hiding this comment.
I think this is a major release because of changes to Node.js and webpack version support. We shouldn't be affected.
Require babel ^7.12.0 and Node.js >= 14.15.0 versions by JLHwung in babel/babel-loader#956
Remove dependency on loader-utils and drop webpack 4 support by nied in babel/babel-loader#942
sirreal
force-pushed
the
security-upgrades
branch
from
94e45da to
38bd6f6
Compare
desrosj
approved these changes
Apr 3, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks! Yes, I think we can land this 🤞 |
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Upgrade babel related dependencies. Dedupe dependencies. Co-authored-by: sirreal <[email protected]> Co-authored-by: desrosj <[email protected]> Co-authored-by: gziolo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
@babel/traverse was flagged as a security issue by dependabot.