DataViews: make deferredRendering prop optional
#57334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Experimental
oandregal
requested review from
ntsekouras,
youknowriad and
jorgefilipecosta
|
Size Change: +7 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Dec 22, 2023
oandregal
deleted the
update/dataviews-make-deferredrendering-optional
branch
|
Flaky tests detected in 2122329. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7298238356
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
Make the
deferredRenderingprop optional.Why?
So consumers don't have to provide it unless they need it.
How?
Sets it to
falseby default.Testing Instructions
Verify that it works as before.
Enable the "admin views" experiment.
Visit "Manage all pages".
Make the preview field visible. Observe how the preview is rendered asynchronously, 3 items at once.
Hide the preview field, and observe how the items are rendered synchronously.
Visit "Manage all templates". Items are rendered synchronously.