Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleGroupControl: Fix snapshots #57367

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Conversation

mirka
Copy link
Member

@mirka mirka commented Dec 25, 2023

Emergency fixup for #57338

What?

Fixes the snapshot tests for ToggleGroupControl, so the unit tests on trunk passes.

Why?

I had auto-merge enabled on #57338, and didn't realize that JS unit tests were not a required check.

@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Dec 25, 2023
@mirka mirka self-assigned this Dec 25, 2023
@mirka mirka requested a review from ajitbohra as a code owner December 25, 2023 17:40
@mirka mirka merged commit c2a54cd into trunk Dec 25, 2023
57 of 58 checks passed
@mirka mirka deleted the fix/toggle-group-control-snapshots branch December 25, 2023 17:54
@github-actions github-actions bot added this to the Gutenberg 17.4 milestone Dec 25, 2023
Copy link

Flaky tests detected in a4413b5.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7323397981
📝 Reported issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant