Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules API: Fix Interactivity not working on Classic Themes. #57396

Merged
merged 5 commits into from
Dec 27, 2023
Merged

Modules API: Fix Interactivity not working on Classic Themes. #57396

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
52553b2
Move modules scripts to footer on classic themes
cbravobernal Dec 27, 2023
f13a53a
Move only required modules
cbravobernal Dec 27, 2023
7c97c8e
Move also the module preloads
cbravobernal Dec 27, 2023
3edb69f
Make preload only for block themes at head
cbravobernal Dec 27, 2023
f77a1e9
Revert "Make preload only for block themes at head"
cbravobernal Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions lib/experimental/modules/class-gutenberg-modules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,14 +262,15 @@ function gutenberg_dequeue_module( $module_identifier ) {
Gutenberg_Modules::dequeue( $module_identifier );
}

// Prints the import map in the head tag.
add_action( 'wp_head', array( 'Gutenberg_Modules', 'print_import_map' ) );
$modules_position = wp_is_block_theme() ? 'wp_head' : 'wp_footer';
// Prints the import map in the head tag in block themes. Otherwise in the footer.
add_action( $modules_position, array( 'Gutenberg_Modules', 'print_import_map' ) );

// Prints the enqueued modules in the head tag.
add_action( 'wp_head', array( 'Gutenberg_Modules', 'print_enqueued_modules' ) );
// Prints the enqueued modules in the head tag in block themes. Otherwise in the footer.
add_action( $modules_position, array( 'Gutenberg_Modules', 'print_enqueued_modules' ) );

// Prints the preloaded modules in the head tag.
add_action( 'wp_head', array( 'Gutenberg_Modules', 'print_module_preloads' ) );
// Prints the preloaded modules in the head tag in block themes. Otherwise in the footer.
add_action( $modules_position, array( 'Gutenberg_Modules', 'print_module_preloads' ) );

// Prints the script that loads the import map polyfill in the footer.
add_action( 'wp_footer', array( 'Gutenberg_Modules', 'print_import_map_polyfill' ), 11 );
Loading