Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Fix Block Appender Accessibility #5742

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Conversation

youknowriad
Copy link
Contributor

closes #4829

This PR adds a label and a role to the appender to make it discoverable by text readers.

@youknowriad youknowriad added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Mar 22, 2018
@youknowriad youknowriad self-assigned this Mar 22, 2018
@youknowriad youknowriad requested a review from afercia March 22, 2018 08:17
@afercia
Copy link
Contributor

afercia commented Mar 22, 2018

@youknowriad thanks.
Sorry for the bad example label used on the screenshot on the issue (Add block (appender)), that was just for testing purposes. I've changed it to Add block and updated the snapshots to make the tests pass.

Maybe we should find a better way to distinguish the controls that insert a new block between existing block (Insert block) from the ones that add a block at the end of the post (Add block), but we can probably iterate later.

@youknowriad
Copy link
Contributor Author

Thanks for the updates @afercia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The blocks "appender" misses a label
2 participants