Migrate 'core settings' e2e tests to Playwright #57581
Conversation
fai-sal
requested review from
kevin940726,
Mamaduka,
ntwb,
nerrad and
ajitbohra
as code owners
fai-sal
changed the title
Mamaduka
added
the
[Type] Automated Testing
|
Thanks for contributing, @fai-sal! Unfortunately, I cannot pull down this branch to test locally. Can make sure you're fork and this branch is up to date - https://developer.wordpress.org/block-editor/contributors/code/git-workflow/#keeping-your-fork-up-to-date? P.S. I would recommend creating a new file for migration instead of moving the test file and then deleting the old test in a separate comment. This makes it more manageable to deal with merge conflicts. |
|
Hi @Mamaduka, Thanks for the feedback!. I have synced the branch with trunk, Can you please retry pulling this branch to test locally. If still no luck then I can create another PR following your recommended approach. |
| const optionsBefore = await getOptionsValues( | ||
| optionsInputsSelector, | ||
| admin, | ||
| page | ||
| ); |
There was a problem hiding this comment.
Note: I'm not sure we can improve this helper. Maybe @kevin940726 has any suggestions.
What
Part of #38851.
PR migrates
core-settings.test.jse2e tests to Playwright.Why
Testing Instructions
npm run test:e2e:playwright -- test/e2e/specs/editor/various/core-settings.spec.js