DataViews: show loading / no result message for the list layout #57764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
youknowriad,
jameskoster,
jorgefilipecosta and
ntsekouras
oandregal
added
[Type] Experimental
|
Size Change: +43 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Thank you. We can land this for now and we'll need the same for grid(either here or in a follow up).
I think we should explore though to handle this no results/loading behavior in the main component so at to have consistency and remove the need for implementation in each view.
I have it on my list to work on a better design for this 👍 |
Yeah, I looked at that briefly. I decided against because I'm not sure that the loading/no result affordance is disconnected from the layout. Examples:
And this is just considering 3 layouts that we know and control. Imagine layouts created by 3rd parties. I felt that abstracting the notice outside of the layout carried more weight than it appeared at first sight, so I thought it'd be best not to right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
Adds a "Loading..." or "No results" message to the list layout.
Why?
To provide users with current information about what's happening.
How?
Adds a notice.
Testing Instructions
isLoading: truesomewhere to see it in action, if it happen too fast.