-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a video demonstration to the Quick Start Guide #57834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅
I just want to note that this approach did not work. The |
@ndiego security concerns make using iframe undesirable, could you try using the Jetpack YouTube shortcode? See WordPress/wordpress.org#188 (comment) |
We probably want to keep the iframe in these docs, and just have the blocks markdown importer on WordPress.org convert it to an embed block or shortcode. |
Yes just discovered why Jetpack isn't doing this, there's a setting which needs to be enabled: It appears to work locally with the markup you've added @ndiego, converting the iframe embed to a shortcode, and then back to an iframe embed on the frontend. Imported contentFrontendThe div with padding you've added to enlarge the video doesn't work due to a nested span, but we could add theme styles for this. I propose we turn on the setting, remove the div from the embed code, and allow the cron to roll out the shortcode. Thoughts? |
That sounds great @adamwoodnz. I will draft another PR with this update. Thanks! |
This PR adds a video demonstration that walks the viewer through the steps in the Quick Start Guide.
The implementation is not ideal, but it works. When docs are synced to developer.wordpress.org/block-editor, the content is wrapped in a Freeform block (Classic Editor). It's not actually converted into a block. This is something that we can explore improving in the future.
Therefore, the YouTube video (hosted as an unlisted video on the WordPress YT channel) cannot use the Embed block and needs some additional markup to maintain its aspect ratio and be responsive. The finished product will look like this:
You can view the video directly here: https://www.youtube.com/watch?v=nrut8SfXA44