Remove the navigation edit button because it leads to a useless screen #59211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
changed the title
draganescu
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -102 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
richtabor
approved these changes
Feb 20, 2024
|
@draganescu @richtabor Are you targetting this for WP 6.5? If so you will need to add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The navigation block exposes an edit button in its toolbar. Clicking that leads the user to a screen where they can edit the navigation contents. Let's remove it because it's useless.
Why?
Editing navigation in isolation never amounted to much and that button creates the illusion that the navigation is not editable in place already. Since we have some discoverability issues around editing menus using the navigation block we don't want any more confusion on top.
How?
Just removed the hook that added the button via a block edit filter.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
After