DataViews: Don't use combobox when there are few available options #59341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
mcsf,
andrewhayward,
jameskoster,
SaxonF and
jorgefilipecosta
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +736 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
I appreciate the effort to get this into 6.5, but I am hesitant to merge because one interaction feels a bit off; when you open a popover the first item is marked active, and as you keyboard up/down the list the active item moves, this is fine. However the active item doesn't move when you cursor over other items, but you do see the hover styles, so it appears there are two active items. Best described with a video: active.mp4It seems like this may be a bug. I noticed in ariakit examples that the |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
ntsekouras
force-pushed
the
dataviews/dont-use-combobox-when-few-items
branch
from
dd59689 to
1bd1833
Compare
This should be fixed and I also added typeahead functionality, so you can start typing and match available options. |
jameskoster
approved these changes
Mar 1, 2024
|
Looks like this component is pretty much a Select. I'm not sure if |
@ndiego thanks for chiming in. I know and that's how I started initially but couldn't make it work without a Also it's okay for now if we have to use Ariakit directly in this component/package. |
jorgefilipecosta
approved these changes
Mar 1, 2024
I understand. I'd actually render the chips (e.g., |
andrewserong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #59230
This PR updates the DataViews search widget of filters, not to use a combobox when we have few options available(now the limit is hardcoded to
10options).These are the four possible versions of a filter.
10options: Show operators->combobox input+list10options: Show operators->listbox10options: Show combobox input+list10options: Show listboxTesting Instructions
Screenshots or screencast
The video is not what's in trunk! It just showcases the four possible versions of a filter.
Screen.Recording.2024-02-24.at.3.00.10.PM.mov