Global Styles: Fix retrieval of referenced preset values in editor #59811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
aaronrobertshaw
requested review from
talldan,
ramonjd,
kevin940726 and
andrewserong
|
I'm open to suggestions if there is a better place to resolve retrieved |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +1 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Thanks for the quick fix!
I tested using the following theme json:
{
"$schema": "https://schemas.wp.org/trunk/theme.json",
"version": 2,
"settings": {
"appearanceTools": true,
"typography": {
"fontSizes": [
{
"name": "Small",
"slug": "small",
"size": "13px"
},
{
"name": "Med",
"slug": "med",
"size": "25px"
}
]
}
},
"styles": {
"blocks":{
"core/heading": {
"typography": {
"fontSize": {
"ref": "styles.elements.h1.typography.fontSize"
}
}
}
}
}
}Then follow the steps in the original issue: #59585
The var is being parsed correctly 👍🏻 custom font sizes aren't affected either
| Before | After |
|---|---|
 |
 |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #59585
What?
Updates the retrieval of values for styles set using
refwithin theme.json to resolve thevar:preset|<type>|<value>preset strings intovar(--wp--preset--type--value)CSS values.Why?
Without this fix, invalid CSS is generated within the editor for styles that
refanother preset value within global styles.How?
Pass the referenced value through
compileStyleValueas happens with non-referenced values.Testing Instructions
Ensure new unit test passes:
npm run test:unit packages/block-editor/src/components/global-styles/test/use-global-styles-output.jsThe easiest means of testing this manually is via the contrived scenario below:
core/headingblock's styles to use arefvalue for itsfontSize(see snippet below)core/headingblock again and confirm its font size rule has a valid CSS value e.g.var(--wp--preset--font-size--xx-large)Screenshots or screencast