Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $schema to tsconfig files #59861

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Add $schema to tsconfig files #59861

merged 3 commits into from
Mar 15, 2024

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Mar 14, 2024

What?

Add $schema to tsconfig files.

Why?

The $schema field provides information about the JSON file that editor integrations can leverage to support developers.
It can also be used for validation, but that's not the goal of this PR.

@sirreal sirreal added [Type] Code Quality Issues or PRs that relate to code quality Developer Experience Ideas about improving block and theme developer experience labels Mar 14, 2024
Copy link

github-actions bot commented Mar 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sirreal <[email protected]>
Co-authored-by: dmsnell <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice easy win, thanks @sirreal

@gziolo gziolo merged commit b6c37f3 into trunk Mar 15, 2024
57 of 58 checks passed
@gziolo gziolo deleted the add/json-schema-tsconfig-entry branch March 15, 2024 09:52
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 15, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Mar 27, 2024
* Add $schema to tsconfig files

* Add another

* Fix schema -> $schema

Co-authored-by: sirreal <[email protected]>
Co-authored-by: dmsnell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Experience Ideas about improving block and theme developer experience [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants