Add text-orientation to the typography block support #60030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
requested review from
tellthemachines,
spacedmonkey,
ellatrix,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @burnuser. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
changed the title
|
Size Change: +786 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
5 tasks
|
@carolinan what's needed to get this merged? Are you happy with it? |
|
The merge conflicts should be solved before testing continues. Then there is some feedback about the alignments in this issue: |
scruffian
force-pushed
the
add/text-orientation-2
branch
from
6e9e6a6 to
61fbd2e
Compare
make the upright text read in the correct direction add textOrientation to the json schema for theme.json CS: try to fix spacing after merge conflict Fix a problem caused by the merge conflict Replace the correct tools panel item. Add textOrientation to the typography styles in the theme.json reference
scruffian
force-pushed
the
add/text-orientation-2
branch
from
61fbd2e to
fd1b396
Compare
|
I have rebased this. Happy for others to commit to the branch to address feedback. |
|
@scruffian neither of these files exist: I am not sure what the error is here: that the files are being imported, or that they are missing? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a text-orientation typography block support, to be combined with the writing mode block support.
Adds support for text-orientation to paragraph blocks.
Follow up to #50822
Closes #50319
Testing Instructions
This setting is disabled by default and can be enabled for themes that include theme.json.
writingMode: trueandtextOrientation: true.Screenshots or screencast
text-orientation.mp4
Props @carolinan who did all the work on this PR