Summary: Polish featured image #60110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +593 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
Let's try that? At the moment it's very close to the size when set, which feels a bit unintentional to me. I think it's worth keeping the border when set, so that it's easier to determine the boundaries when an image with white background is selected. This also matches the treatment in data views. 
|
Agreed, when set. |
richtabor
reviewed
Mar 22, 2024
| outline-offset: -#{$border-width}; | ||
| min-height: $grid-unit-50 * 2; | ||
| margin-bottom: $grid-unit-10; |
There was a problem hiding this comment.
If we use $grid-unit-20, the space between this and each other item in the summary is the same:
|
Great feedback. Took a stab. Now the border is present when a featured image is set:
I applied the suggested bottom margin, and set the height to 56px:
What's a good height here? Here's what 40px would look like:
|
|
I thought what you had was fine, at 80px. |
|
Cool, restored the 80px:
We can always review this. |
jameskoster
approved these changes
Mar 22, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
* Polish featured image. * Address feedback. * Restore 80px. Co-authored-by: jasmussen <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: jameskoster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Polishes the featured image component of the new summary panel, and makes it less prominent when unset. Here's a screenshot of the component in trunk:
Featured images are nice, but many posts and pages are not going to have them, or even need them. So for the unset state, it should not be quite as prominent as here. In fact, we probably want to go even smaller than what this PR does.
For now, I've pulled this down to be smaller, about the size it was before:
It still grows to a 2:1 aspect ratio when a featured image is set:
I also removed the border. It wasn't there before, and in general this "dropzone" component we use elsewhere, borderless, such as in the font library, so it's probably best to not diverge:
So this PR:
Testing Instructions
Obsere the post or page summary panel, and observe changes to the featured image as unset.