Consolidate when showing revisions link or action #60194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +29 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
I agree it doesn't make sense to provide access to the revisions UI when there are no revisions that can be restored. There's a small quirk however for theme-supplied templates and template parts. I suppose it's because a new record is created in the db instead of the theme file being 'edited'. In terms of UX it produces a counter-intuitive experience: if you edit a template supplied by the theme and save, you can immediately 'clear customizations', which suggests there is at least one revision. But there is no way to view revisions (because technically none exist). It's a minor detail, so probably fine to merge. But it'd be good to hear any ideas how we might smooth out this wrinkle. |
|
@jameskoster who else should we ping to get some more opinions? Maybe @richtabor ? |
jameskoster
approved these changes
Apr 2, 2024
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: kathrynwp <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: annezazu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #56603
This should be the last part of the issue and this PR consolidates when to show the
view revisionslink/action. It uses the same logic we were using for lists, which is show the link/action if there are more than one revision. This effectively means that we don't show the first revision from empty content, which by the way is a revision that cannot be 'restored'.Testing Instructions