Site Editor: Reuse inserter search term normalization #60218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Feature] Inserter
tyxla
requested review from
fullofcaffeine,
jsnajdr,
glendaviesnz,
ramonjd,
aaronrobertshaw and
a team
|
Size Change: -55 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
LGTM
extractWords and normalizeString are now private exports from packages/block-editor/src/components/inserter/search-items.js and don't occur anywhere else
Searching inserter works as expected in post and site editors, testing using some accents as well. 👍🏻
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aaronrobertshaw
approved these changes
Mar 27, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
* Block Editor: Expose inserter search term normalization utils * Edit Site: Use search term normalization utils from block editor * Edit Site: Remove remove-accents dependency Co-authored-by: tyxla <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: jsnajdr <[email protected]>
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
* Block Editor: Expose inserter search term normalization utils * Edit Site: Use search term normalization utils from block editor * Edit Site: Remove remove-accents dependency Co-authored-by: tyxla <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: jsnajdr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #60080 (comment) @jsnajdr spotted that much of the search term normalization logic is being duplicated.
This PR deduplicates a big part of the search term normalization functionality that is essentially copied from the block editor.
Why?
To avoid duplication and to reuse code that already has some testing coverage.
How?
We're exposing those utilities as private APIs for the block editor and reusing them in the site editor. This also allows us to remove a direct dependency from the
edit-sitepackage.There are more opportunities for deduplication, but I prefer addressing them in smaller and more digestible pieces.
Testing Instructions
Testing Instructions for Keyboard
None
Screenshots or screencast
None