Fix external link indicator in Link Control #60439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jasmussen
approved these changes
Apr 3, 2024
|
Size Change: +2.51 kB (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
t-hamano
requested changes
Apr 8, 2024
There was a problem hiding this comment.
If the text is long, it seems like it won't be one line after applying this PR.
trunk
This PR
I think this is because the display: -webkit-box for truncating the text is overwritten with the inline value:
Is it possible to adjust the appearance while maintaining the current number of lines?
|
From brief testing, the following style appears to solve the problem. .block-editor-link-control__search-item .block-editor-link-control__search-item-title {
display: flex;
} |
|
Back in the day, one hack to avoid breaking a word in two despite there being a space, was to insert a non breaking space character, |
That didn't quite work either, as it renders all the way to the right of the available area, regardless of truncation.
|
|
I realized that trunk intentionally hides the previous external link SVG icon. I updated this to target the .components-external-link__icon class, rather than |
I also agree with this approach. This is because the link may not be an external resource such as an anchor. @jasmussen What do you think? |
|
I.e. hide the external link entirely, as was the case before? Sounds good, there's likely good past context for that good to not accidentally revert. |
t-hamano
approved these changes
Apr 9, 2024
|
Sorry, I accidentally sent a re-review to @jasmussen 😅 |
|
Rebased to get tests ✅ |
jeryj
reviewed
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #60255 for Link Control.
Testing Instructions
Screenshots or screencast