Zoom-out: scale should be stable function #60580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +2 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
jeryj
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
I think this change makes sense to simplify the effect.
However, the zoom-out use case is passing a new function on every render, triggering the effect on every render as well.
I don't see the performance improvement part of this though. The effect looks like it's running the same amount of times on trunk vs this branch when toggling between zoom out mode. Could you point me to how you debugged this and saw the performance improvement?
|
@jeryj Apologies, I saw this while working on Prevent resizing from triggering re-renders, this would just be a preventative measure I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #59618, the iframe's scale prop was changed so a function can be passed. However, the zoom-out use case is passing a new function on every render, triggering the effect on every render as well.
Either we should:
I opted for the latter since the function seems like it's simple math (so fast) and this keeps the API simpler to use.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast